Files
pic/tests/test_routing_endpoints.py
roof a43f9fbf0d fix: full security audit remediation — P0/P1/P2/P3 fixes + 1020 passing tests
P0 — Broken functionality:
- Fix 12+ endpoints with wrong manager method signatures (email/calendar/file/routing)
- Fix email_manager.delete_email_user() missing domain arg
- Fix cell-link DNS forwarding wiped on every peer change (generate_corefile now
  accepts cell_links param; add/remove_cell_dns_forward no longer clobber the file)
- Fix Flask SECRET_KEY regenerating on every restart (persisted to DATA_DIR)
- Fix _next_peer_ip exhaustion returning 500 instead of 409
- Fix ConfigManager Caddyfile path (/app/config-caddy/)
- Fix UI double-add and wrong-key peer bugs in Peers.jsx / WireGuard.jsx
- Remove hardcoded credentials from Dashboard.jsx

P1 — Security:
- CSRF token validation on all POST/PUT/DELETE/PATCH to /api/* (double-submit pattern)
- enforce_auth: 503 only when users file readable but empty; never bypass on IOError
- WireGuard add_cell_peer: validate pubkey, name, endpoint against strict regexes
- DNS add_cell_dns_forward: validate IP and domain; reject injection chars
- DNS zone write: realpath containment + record content validation
- iptables comment /32 suffix prevents substring match deleting wrong peer rules
- is_local_request() trusts only loopback + 172.16.0.0/12 (Docker bridge)
- POST /api/containers: volume allow-list prevents arbitrary host mounts
- file_manager: bcrypt ($2b→$2y) for WebDAV; realpath containment in delete_user
- email/calendar: stop persisting plaintext passwords in user records
- routing_manager: validate IPs, networks, and interface names
- peer_registry: write peers.json at mode 0o600
- vault_manager: Fernet key file at mode 0o600
- CORS: lock down to explicit origin list
- domain/cell_name validation: reject newline, brace, semicolon injection chars

P2 — Architecture:
- Peer add: rollback registry entry if firewall rules fail post-add
- restart_service(): base class now calls _restart_container(); email and calendar
  managers call cell-mail / cell-radicale respectively
- email/calendar managers sync user list (no passwords) to cell_config.json
- Pending-restart flag cleared only after helper subprocess exits with code 0
- docker-compose.yml: add config-caddy volume to API container

P3 — Tests (854 → 1020):
- Fill test_email_endpoints.py, test_calendar_endpoints.py,
  test_network_endpoints.py, test_routing_endpoints.py
- New: test_peer_management_update.py, test_peer_management_edge_cases.py,
  test_input_validation.py, test_enforce_auth_configured.py,
  test_cell_link_dns.py, test_logs_endpoints.py, test_cells_endpoints.py,
  test_is_local_request_per_endpoint.py, test_caddy_routing.py
- E2E conftest: skip WireGuard suite when wg-quick absent
- Update existing tests to match fixed signatures and comment formats

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-27 11:30:21 -04:00

295 lines
11 KiB
Python

#!/usr/bin/env python3
"""
Unit tests for routing Flask endpoints in api/app.py.
Covers:
POST /api/routing/peers (peer_name + peer_ip required)
POST /api/routing/exit-nodes (peer_name + peer_ip required)
POST /api/routing/bridge (source_peer + target_peer required)
POST /api/routing/split (network + exit_peer required)
GET /api/routing/peers
DELETE /api/routing/peers/<name>
"""
import sys
import json
import unittest
from pathlib import Path
from unittest.mock import patch, MagicMock
api_dir = Path(__file__).parent.parent / 'api'
sys.path.insert(0, str(api_dir))
from app import app
class TestAddPeerRoute(unittest.TestCase):
def setUp(self):
app.config['TESTING'] = True
self.client = app.test_client()
@patch('app.routing_manager')
def test_add_peer_route_returns_200_on_success(self, mock_rm):
mock_rm.add_peer_route.return_value = True
r = self.client.post(
'/api/routing/peers',
data=json.dumps({'peer_name': 'alice', 'peer_ip': '10.0.0.2'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 200)
data = json.loads(r.data)
self.assertIn('added', data)
@patch('app.routing_manager')
def test_add_peer_route_returns_400_when_peer_name_missing(self, mock_rm):
r = self.client.post(
'/api/routing/peers',
data=json.dumps({'peer_ip': '10.0.0.2'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_peer_route.assert_not_called()
@patch('app.routing_manager')
def test_add_peer_route_returns_400_when_peer_ip_missing(self, mock_rm):
r = self.client.post(
'/api/routing/peers',
data=json.dumps({'peer_name': 'alice'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_peer_route.assert_not_called()
@patch('app.routing_manager')
def test_add_peer_route_returns_500_on_exception(self, mock_rm):
mock_rm.add_peer_route.side_effect = Exception('iptables error')
r = self.client.post(
'/api/routing/peers',
data=json.dumps({'peer_name': 'alice', 'peer_ip': '10.0.0.2'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 500)
self.assertIn('error', json.loads(r.data))
class TestAddExitNode(unittest.TestCase):
def setUp(self):
app.config['TESTING'] = True
self.client = app.test_client()
@patch('app.routing_manager')
def test_add_exit_node_returns_200_on_success(self, mock_rm):
mock_rm.add_exit_node.return_value = True
r = self.client.post(
'/api/routing/exit-nodes',
data=json.dumps({'peer_name': 'gw', 'peer_ip': '10.0.0.5'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 200)
data = json.loads(r.data)
self.assertIn('added', data)
@patch('app.routing_manager')
def test_add_exit_node_returns_400_when_peer_name_missing(self, mock_rm):
r = self.client.post(
'/api/routing/exit-nodes',
data=json.dumps({'peer_ip': '10.0.0.5'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_exit_node.assert_not_called()
@patch('app.routing_manager')
def test_add_exit_node_returns_400_when_peer_ip_missing(self, mock_rm):
r = self.client.post(
'/api/routing/exit-nodes',
data=json.dumps({'peer_name': 'gw'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_exit_node.assert_not_called()
@patch('app.routing_manager')
def test_add_exit_node_returns_500_on_exception(self, mock_rm):
mock_rm.add_exit_node.side_effect = Exception('routing table full')
r = self.client.post(
'/api/routing/exit-nodes',
data=json.dumps({'peer_name': 'gw', 'peer_ip': '10.0.0.5'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 500)
self.assertIn('error', json.loads(r.data))
class TestAddBridgeRoute(unittest.TestCase):
def setUp(self):
app.config['TESTING'] = True
self.client = app.test_client()
@patch('app.routing_manager')
def test_add_bridge_returns_200_on_success(self, mock_rm):
mock_rm.add_bridge_route.return_value = True
r = self.client.post(
'/api/routing/bridge',
data=json.dumps({'source_peer': 'alice', 'target_peer': 'bob'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 200)
data = json.loads(r.data)
self.assertIn('added', data)
@patch('app.routing_manager')
def test_add_bridge_returns_400_when_source_peer_missing(self, mock_rm):
r = self.client.post(
'/api/routing/bridge',
data=json.dumps({'target_peer': 'bob'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_bridge_route.assert_not_called()
@patch('app.routing_manager')
def test_add_bridge_returns_400_when_target_peer_missing(self, mock_rm):
r = self.client.post(
'/api/routing/bridge',
data=json.dumps({'source_peer': 'alice'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_bridge_route.assert_not_called()
@patch('app.routing_manager')
def test_add_bridge_returns_500_on_exception(self, mock_rm):
mock_rm.add_bridge_route.side_effect = Exception('bridge setup failed')
r = self.client.post(
'/api/routing/bridge',
data=json.dumps({'source_peer': 'alice', 'target_peer': 'bob'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 500)
self.assertIn('error', json.loads(r.data))
class TestAddSplitRoute(unittest.TestCase):
def setUp(self):
app.config['TESTING'] = True
self.client = app.test_client()
@patch('app.routing_manager')
def test_add_split_returns_200_on_success(self, mock_rm):
mock_rm.add_split_route.return_value = True
r = self.client.post(
'/api/routing/split',
data=json.dumps({'network': '192.168.10.0/24', 'exit_peer': 'gw'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 200)
data = json.loads(r.data)
self.assertIn('added', data)
@patch('app.routing_manager')
def test_add_split_returns_400_when_network_missing(self, mock_rm):
r = self.client.post(
'/api/routing/split',
data=json.dumps({'exit_peer': 'gw'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_split_route.assert_not_called()
@patch('app.routing_manager')
def test_add_split_returns_400_when_exit_peer_missing(self, mock_rm):
r = self.client.post(
'/api/routing/split',
data=json.dumps({'network': '192.168.10.0/24'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 400)
self.assertIn('error', json.loads(r.data))
mock_rm.add_split_route.assert_not_called()
@patch('app.routing_manager')
def test_add_split_returns_500_on_exception(self, mock_rm):
mock_rm.add_split_route.side_effect = Exception('split tunnel error')
r = self.client.post(
'/api/routing/split',
data=json.dumps({'network': '192.168.10.0/24', 'exit_peer': 'gw'}),
content_type='application/json',
)
self.assertEqual(r.status_code, 500)
self.assertIn('error', json.loads(r.data))
class TestGetPeerRoutes(unittest.TestCase):
def setUp(self):
app.config['TESTING'] = True
self.client = app.test_client()
@patch('app.routing_manager')
def test_get_peer_routes_returns_200_with_routes(self, mock_rm):
mock_rm.get_peer_routes.return_value = [
{'peer_name': 'alice', 'peer_ip': '10.0.0.2', 'route_type': 'lan'},
]
r = self.client.get('/api/routing/peers')
self.assertEqual(r.status_code, 200)
data = json.loads(r.data)
self.assertIn('peer_routes', data)
self.assertIsInstance(data['peer_routes'], list)
@patch('app.routing_manager')
def test_get_peer_routes_returns_empty_list_when_no_routes(self, mock_rm):
mock_rm.get_peer_routes.return_value = []
r = self.client.get('/api/routing/peers')
self.assertEqual(r.status_code, 200)
data = json.loads(r.data)
self.assertEqual(data['peer_routes'], [])
@patch('app.routing_manager')
def test_get_peer_routes_returns_500_on_exception(self, mock_rm):
mock_rm.get_peer_routes.side_effect = Exception('DB error')
r = self.client.get('/api/routing/peers')
self.assertEqual(r.status_code, 500)
self.assertIn('error', json.loads(r.data))
class TestDeletePeerRoute(unittest.TestCase):
def setUp(self):
app.config['TESTING'] = True
self.client = app.test_client()
@patch('app.routing_manager')
def test_delete_peer_route_returns_200_on_success(self, mock_rm):
mock_rm.remove_peer_route.return_value = {'removed': True}
r = self.client.delete('/api/routing/peers/alice')
self.assertEqual(r.status_code, 200)
@patch('app.routing_manager')
def test_delete_peer_route_calls_manager_with_name(self, mock_rm):
mock_rm.remove_peer_route.return_value = {'removed': True}
self.client.delete('/api/routing/peers/bob')
mock_rm.remove_peer_route.assert_called_once_with('bob')
@patch('app.routing_manager')
def test_delete_peer_route_returns_500_on_exception(self, mock_rm):
mock_rm.remove_peer_route.side_effect = Exception('iptables flush error')
r = self.client.delete('/api/routing/peers/alice')
self.assertEqual(r.status_code, 500)
self.assertIn('error', json.loads(r.data))
if __name__ == '__main__':
unittest.main()