roof/pic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: use api_base fixture instead of hardcoded pic0 IP in WG domain access tests

Browse Source 
test_peer_services_* functions hardcoded 'http://192.168.31.51:3000' as the
fallback for PIC_API_BASE, causing failures when tests run on any other host
(including pic1 itself). Use the api_base fixture, which reads PIC_HOST and
PIC_API_PORT from the environment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Dmitrii Iurco
2026-06-06 08:06:29 -04:00
parent 463db029e1
commit 352bb6bb9e
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/wg/test_wg_domain_access.py
+4 -6
View File
@@ -153,13 +153,12 @@ def test_http_api_domain_reaches_api(connected_peer, admin_client):
# ── Scenario 33: Config DNS field ───────────────────────────────────────────── # ── Scenario 33: Config DNS field ─────────────────────────────────────────────
def test_peer_services_config_has_coredns_not_vpn_gateway(admin_client, make_peer): def test_peer_services_config_has_coredns_not_vpn_gateway(admin_client, make_peer, api_base):
"""WireGuard config in /api/peer/services must use CoreDNS IP, not 10.0.0.1.""" """WireGuard config in /api/peer/services must use CoreDNS IP, not 10.0.0.1."""
from helpers.api_client import PicAPIClient from helpers.api_client import PicAPIClient
import os
peer = make_peer('e2etest-dns-config', password='DnsTest123!') peer = make_peer('e2etest-dns-config', password='DnsTest123!')
peer_client = PicAPIClient(os.environ.get('PIC_API_BASE', 'http://192.168.31.51:3000')) peer_client = PicAPIClient(api_base)
peer_client.login(peer['name'], 'DnsTest123!') peer_client.login(peer['name'], 'DnsTest123!')
r = peer_client.get('/api/peer/services') r = peer_client.get('/api/peer/services')
@@ -188,14 +187,13 @@ def test_peer_services_config_has_coredns_not_vpn_gateway(admin_client, make_pee
break break
def test_peer_services_caldav_url_uses_configured_domain(admin_client, make_peer): def test_peer_services_caldav_url_uses_configured_domain(admin_client, make_peer, api_base):
"""CalDAV URL must use the configured domain, not hardcode 'radicale.dev:5232'.""" """CalDAV URL must use the configured domain, not hardcode 'radicale.dev:5232'."""
from helpers.api_client import PicAPIClient from helpers.api_client import PicAPIClient
import os
dom = _domain(admin_client) dom = _domain(admin_client)
peer = make_peer('e2etest-caldav-url', password='CaldavTest123!') peer = make_peer('e2etest-caldav-url', password='CaldavTest123!')
peer_client = PicAPIClient(os.environ.get('PIC_API_BASE', 'http://192.168.31.51:3000')) peer_client = PicAPIClient(api_base)
peer_client.login(peer['name'], 'CaldavTest123!') peer_client.login(peer['name'], 'CaldavTest123!')
r = peer_client.get('/api/peer/services') r = peer_client.get('/api/peer/services')