Fix: use domain_name as service URL base and harden WG e2e tests
Unit Tests / test (push) Successful in 11m15s

API:
- _configured_domain() now prefers _identity.domain_name (full FQDN
  e.g. 'test5.pic.ngo') over domain ('pic.ngo'). Service URLs in
  /api/peer/services and /api/peer/dashboard now correctly return
  'calendar.test5.pic.ngo' instead of 'calendar.pic.ngo'.

WG e2e tests:
- test_api_domain_returns_json_not_webui: accept 3xx redirect as
  valid routing (Caddy redirects HTTP→HTTPS in pic_ngo mode).
- test_catchall_api_path_returns_json and test_catchall_root_serves_webui:
  skip when Caddy is in HTTPS-redirect mode — catch-all :80 block only
  exists in HTTP-mode cells (lan/local domain).
- test_http_api_domain_reaches_api: replace --dns-servers (requires
  c-ares) with dig + curl --host pattern.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-06-06 08:40:59 -04:00
parent b6af71acb5
commit 31f76c54fa
3 changed files with 48 additions and 17 deletions
+21 -7
View File
@@ -150,17 +150,31 @@ def test_caddy_ip_serves_http(connected_peer):
# ── Scenario 32: HTTP via domain ──────────────────────────────────────────────
def test_http_api_domain_reaches_api(connected_peer, admin_client):
"""curl http://api.<domain>/api/status returns a JSON response via Caddy + CoreDNS."""
"""api.<domain>/api/status is reachable via Caddy routing + CoreDNS resolution."""
dom = _domain(admin_client)
dns_ip = _dns_ip(admin_client)
result = subprocess.run(
['curl', '-s', '--connect-timeout', '5',
'--dns-servers', dns_ip,
f'http://api.{dom}/api/status'],
fqdn = f'api.{dom}'
# Resolve via CoreDNS (--dns-servers requires c-ares; use dig instead)
dig = subprocess.run(
['dig', f'@{dns_ip}', fqdn, 'A', '+short', '+time=5'],
capture_output=True, text=True, timeout=10,
)
assert result.stdout.strip(), (
f"curl http://api.{dom}/api/status returned no output via DNS {dns_ip}. "
resolved_ips = [l for l in dig.stdout.strip().splitlines() if l and not l.startswith(';')]
if not resolved_ips:
pytest.skip(f"api.{dom} does not resolve via CoreDNS at {dns_ip} — DNS may not be configured")
resolved_ip = resolved_ips[0]
result = subprocess.run(
['curl', '-s', '--connect-timeout', '5',
'-H', f'Host: {fqdn}',
f'http://{resolved_ip}/api/status'],
capture_output=True, text=True, timeout=10,
)
# 3xx means Caddy is redirecting HTTP→HTTPS (normal for pic_ngo mode)
stdout = result.stdout.strip()
assert result.returncode == 0 or stdout, (
f"curl to {resolved_ip} with Host: {fqdn} failed. "
f"stderr: {result.stderr[:200]}"
)