roof/pic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: subprocess not imported in _do_apply background thread

Browse Source 
The apply_pending_config endpoint spawns _do_apply in a background thread.
subprocess was used but not imported inside the closure, causing
NameError: name 'subprocess' is not defined on every Apply click —
silently swallowed, so containers never restarted and no error was shown.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Dmitrii Iurco
2026-04-22 14:28:13 -04:00
parent 7e58300b6c
commit 11c80124af
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/app.py
+3 -2
View File
@@ -712,14 +712,15 @@ def apply_pending_config():
# Run in a background thread; 0.3 s delay lets Flask send this response first. # Run in a background thread; 0.3 s delay lets Flask send this response first.
def _do_apply(): def _do_apply():
import time as _time import time as _time
import subprocess as _subprocess
_time.sleep(0.3) _time.sleep(0.3)
if compose_down_args: if compose_down_args:
r = subprocess.run(base_cmd + compose_down_args, r = _subprocess.run(base_cmd + compose_down_args,
capture_output=True, text=True, timeout=60) capture_output=True, text=True, timeout=60)
if r.returncode != 0: if r.returncode != 0:
logger.error(f"docker compose down failed: {r.stderr.strip()}") logger.error(f"docker compose down failed: {r.stderr.strip()}")
return return
result = subprocess.run(base_cmd + compose_up_args, result = _subprocess.run(base_cmd + compose_up_args,
capture_output=True, text=True, timeout=120) capture_output=True, text=True, timeout=120)
if result.returncode != 0: if result.returncode != 0:
logger.error(f"docker compose up failed: {result.stderr.strip()}") logger.error(f"docker compose up failed: {result.stderr.strip()}")